Container resource detectors + manage resource detectors #2415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kielek
force-pushed
the
resource-detectors
branch
2 times, most recently
from
826715c to
91ef94a
Compare
Kielek
force-pushed
the
resource-detectors
branch
from
91ef94a to
4e6ac2e
Compare
pellared
reviewed
Apr 6, 2023
src/OpenTelemetry.AutoInstrumentation/Configurations/ResourceDetector.cs
Outdated
Show resolved
Hide resolved
Kielek
changed the title
nrcventura
reviewed
Apr 7, 2023
src/OpenTelemetry.AutoInstrumentation/Configurations/ConfigurationKeys.cs
Outdated
Show resolved
Hide resolved
Member
|
Changes in this PR looks good to me. Once this conversation #2415 (comment) is sorted we could merge. |
pellared
reviewed
Apr 11, 2023
theletterf
approved these changes
Apr 11, 2023
pjanotti
reviewed
Apr 12, 2023
Contributor
pjanotti
left a comment
pjanotti
left a comment
There was a problem hiding this comment.
There are few minor suggestion in the reviews, but, seems ready to merge after the spec Q is clarified.
test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/SettingsTests.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Apr 13, 2023
Kielek
force-pushed
the
resource-detectors
branch
from
6e63924 to
34abca9
Compare
pellared
approved these changes
Apr 13, 2023
Kielek
force-pushed
the
resource-detectors
branch
from
ad519b8 to
b38c268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #2414
What
Container resource detectors + manage resource detectors
by
OTEL_DOTNET_AUTO_RESOURCE_DETECTOR_ENABLEDOTEL_DOTNET_AUTO_{0}_RESOURCE_DETECTOR_ENABLED.Available resource detectors:
ENVIRONMENTALVARIABLESTELEMETRYSDKCONTAINERTests
CI
Checklist
CHANGELOG.mdis updated.WIP
For now, it is referencing obsolete Docker package, the new one will be released after merge:
open-telemetry/opentelemetry-dotnet-contrib#1132
DistributionStructureandModuleTeststests will be updated with new package