Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Jan 4, 2024

Why

Fixes #3204

What

Bump OTel packages to 1.7.0. It includes bumping of indirect dependencies. For details, please check CHANGELOG.
Documentation updated.
Tests adjustment.

Tests

CI

Checklist

  • CHANGELOG.md is updated.
  • Documentation is updated.
  • New features are covered by tests.

@Kielek Kielek marked this pull request as ready for review January 5, 2024 12:56
@Kielek Kielek requested a review from a team January 5, 2024 12:56
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general concern are the explicit reference to some of the Microsoft.Extensions.* packages that were moved to version 8.0 - it seems that if we needed to those for tests many users will have to do the same. That said it is a known issue if there are conflicting versions brought by the application.

Could you just verify that these are really being brought by the test applications? Just to ensure that we are not missing anything on AdditionalDeps and SharedStore.

@Kielek
Copy link
Member Author

Kielek commented Jan 9, 2024

A general concern are the explicit reference to some of the Microsoft.Extensions.* packages that were moved to version 8.0 - it seems that if we needed to those for tests many users will have to do the same. That said it is a known issue if there are conflicting versions brought by the application.

Could you just verify that these are really being brought by the test applications? Just to ensure that we are not missing anything on AdditionalDeps and SharedStore.

Double checked, all libraries are transitive dependencies referenced by instrumented libraries.

@Kielek Kielek enabled auto-merge (squash) January 10, 2024 17:30
@Kielek Kielek merged commit 9a96610 into open-telemetry:main Jan 10, 2024
@Kielek Kielek deleted the bump-otel-1.7.0 branch January 11, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump OTel to 1.7.0.

5 participants