Add checker for passing correct sampling decision for xray#1355
Merged
cijothomas merged 10 commits intoopen-telemetry:masterfrom Jan 14, 2021
lupengamzn:master
Merged
Add checker for passing correct sampling decision for xray#1355cijothomas merged 10 commits intoopen-telemetry:masterfrom lupengamzn:master
cijothomas merged 10 commits intoopen-telemetry:masterfrom
lupengamzn:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
- Coverage 82.09% 82.08% -0.02%
==========================================
Files 249 249
Lines 6730 6730
==========================================
- Hits 5525 5524 -1
- Misses 1205 1206 +1
|
CodeBlanch
reviewed
Oct 15, 2020
cijothomas
reviewed
Jan 5, 2021
cijothomas
approved these changes
Jan 7, 2021
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
Please add changelog.md entry as well befiore merge.
Member
|
@lupengamzn Please check the CI failures and resolve them. |
Contributor
Author
@cijothomas Just fixed, thanks |
CodeBlanch
reviewed
Jan 13, 2021
cijothomas
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1268 (comment) and #1240, added the checker for passing correct sampling decision while using xray's trace id generator.