Added ServiceName option to OtlpExporter#1420
Merged
cijothomas merged 6 commits intoopen-telemetry:masterfrom Oct 30, 2020
Merged
Added ServiceName option to OtlpExporter#1420cijothomas merged 6 commits intoopen-telemetry:masterfrom
cijothomas merged 6 commits intoopen-telemetry:masterfrom
Conversation
eddynaka
approved these changes
Oct 29, 2020
cijothomas
approved these changes
Oct 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
+ Coverage 81.31% 81.87% +0.56%
==========================================
Files 227 227
Lines 6117 6086 -31
==========================================
+ Hits 4974 4983 +9
+ Misses 1143 1103 -40
|
Member
Author
|
@eddynaka @cijothomas Would you guys mind taking another look at this? In order to make the tests work I had to switch the resource from a static on |
Contributor
@CodeBlanch , took a look. Looks fine. Don't think that will affect performance/allocation much. |
cijothomas
approved these changes
Oct 30, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1416
Changes
Add
ServiceNameoption to OtlpExporter to bring it into parity with Zipkin & Jaeger.TODOs:
CHANGELOG.mdupdated for non-trivial changes