Update OtlpExporter options#1781
Merged
cijothomas merged 8 commits intoopen-telemetry:mainfrom Feb 3, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 84.09% 83.89% -0.20%
==========================================
Files 187 187
Lines 5935 5956 +21
==========================================
+ Hits 4991 4997 +6
- Misses 944 959 +15
|
CodeBlanch
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpTraceExporter.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Feb 3, 2021
reyang
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpTraceExporter.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Feb 3, 2021
cijothomas
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpTraceExporter.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
johnduhart
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Feb 3, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Feb 3, 2021
| return Task.WaitAny(new Task[] { this.channel.ShutdownAsync(), Task.Delay(timeoutMilliseconds) }) == 0; | ||
| } | ||
|
|
||
| private static Metadata GetMetadataFromHeaders(string headers) |
Member
There was a problem hiding this comment.
we'll need unit test for this. (okay to add in separate PR)
…utpilla/opentelemetry-dotnet into utpilla/Fix-OtlpExporterOptions
cijothomas
reviewed
Feb 3, 2021
cijothomas
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1778
Changes
CHANGELOG.mdupdated for non-trivial changes