Merged
Conversation
…expected to come from the API callbacks (#2134)
Update DiagnosticSource version
Codecov Report
@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
- Coverage 82.12% 74.57% -7.56%
==========================================
Files 250 218 -32
Lines 6774 6957 +183
==========================================
- Hits 5563 5188 -375
- Misses 1211 1769 +558
|
alanwest
reviewed
Jul 22, 2021
Comment on lines
-9
to
-11
| <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="$(MicrosoftCodeAnalysisAnalyzersPkgVer)" Condition=" $(OS) == 'Windows_NT'"> | ||
| <PrivateAssets>All</PrivateAssets> | ||
| </PackageReference> |
Member
There was a problem hiding this comment.
We will continue to leave this disabled on main for now?
alanwest
reviewed
Jul 22, 2021
Comment on lines
+10
to
+12
| * Removed existing Metrics code as the spec is completely being re-written. | ||
| ([#2030](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2030)) | ||
|
|
Member
There was a problem hiding this comment.
Might make sense to update this changelog to reflect the new state of things.
alanwest
reviewed
Jul 22, 2021
Comment on lines
+10
to
+11
| * Removed existing Metrics code as the spec is completely being re-written. | ||
| ([#2030](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2030)) |
Member
There was a problem hiding this comment.
Same thing for the SDK changelog
alanwest
reviewed
Jul 22, 2021
| } | ||
|
|
||
| [Fact] | ||
| [Fact(Skip = "Get around GitHub failure")] |
Member
There was a problem hiding this comment.
Is it still necessary to skip this test on the main branch?
reyang
reviewed
Jul 22, 2021
| * `Status.WithDescription` will now ignore the provided description if the | ||
| `Status.StatusCode` is anything other than `ERROR`. | ||
| ([#1655](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1655)) | ||
| * Metrics removed as it is not part 1.0.0 release. See issue |
reyang
approved these changes
Jul 22, 2021
Member
reyang
left a comment
reyang
left a comment
There was a problem hiding this comment.
LGTM. After this PR got merged, might need to update the CI definition by removing metrics branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are prepping for 1.2.0-alpha1 release. 1.2.0 is the next planned release, and now we can work in main branch for metrics code as well.