Skip to content

Implement the metrics dispose/shutdown logic #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 5 commits into from
Sep 23, 2021
Merged

Implement the metrics dispose/shutdown logic #2404

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ca0a39
Implement the metrics dispose/shutdown logic
reyang Sep 23, 2021
9cb186a
improve indentation
reyang Sep 23, 2021
f572c50
update test cases
reyang Sep 23, 2021
e6f98b6
Update docs/metrics/getting-started/Program.cs
reyang Sep 23, 2021
8be85bd
nits
reyang Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve indentation
  • Loading branch information
@reyang
reyang committed Sep 23, 2021
commit 9cb186a46ff9dadf5644d7db1cd44feab2fb02cd
12 changes: 6 additions & 6 deletions docs/metrics/getting-started/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ public static void Main(string[] args)

var counter = MyMeter.CreateCounter<long>("MyCounter");

counter.Add(1, new("name", "orange"), new("color", "orange"));
counter.Add(2, new("name", "lemon"), new("color", "yellow"));
counter.Add(3, new("name", "lime"), new("color", "green"));
counter.Add(2, new("name", "orange"), new("color", "green"));
counter.Add(5, new("name", "orange"), new("color", "orange"));
counter.Add(8, new("name", "lime"), new("color", "green"));
counter.Add(1, new("name", "apple"), new("color", "red"));
counter.Add(2, new("name", "lemon"), new("color", "yellow"));
counter.Add(1, new("name", "lemon"), new("color", "yellow"));
counter.Add(2, new("name", "apple"), new("color", "green"));
counter.Add(5, new("name", "apple"), new("color", "red"));
counter.Add(4, new("name", "lemon"), new("color", "yellow"));
Copy link
Contributor

@mic-max mic-max Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this new example topic!

}
}
10 changes: 4 additions & 6 deletions docs/metrics/getting-started/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,11 @@ output from the console, similar to shown below:
<!-- markdownlint-disable MD013 -->
```text
Export MyCounter, Meter: MyCompany.MyProduct.MyLibrary/1.0
2021-09-23T02:20:58.8168802Z, 2021-09-23T02:20:58.8359677Z] color:orangename:orange LongSum
2021-09-23T03:17:30.6198292Z, 2021-09-23T03:17:30.6356517Z] color:redname:apple LongSum
Value: 6
2021-09-23T02:20:58.8168802Z, 2021-09-23T02:20:58.8359677Z] color:yellowname:lemon LongSum
Value: 2
2021-09-23T02:20:58.8168802Z, 2021-09-23T02:20:58.8359677Z] color:greenname:lime LongSum
Value: 11
2021-09-23T02:20:58.8168802Z, 2021-09-23T02:20:58.8359677Z] color:greenname:orange LongSum
2021-09-23T03:17:30.6198292Z, 2021-09-23T03:17:30.6356517Z] color:yellowname:lemon LongSum
Value: 7
2021-09-23T03:17:30.6198292Z, 2021-09-23T03:17:30.6356517Z] color:greenname:apple LongSum
Value: 2
```
<!-- markdownlint-enable MD013 -->
Expand Down