OtlpExporter: HttpClientFactory option#2696
Merged
cijothomas merged 14 commits intoopen-telemetry:mainfrom Nov 29, 2021
Merged
Conversation
CodeBlanch
commented
Nov 28, 2021
...ry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/OtlpHttpMetricsExportClient.cs
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2696 +/- ##
==========================================
+ Coverage 82.95% 84.05% +1.09%
==========================================
Files 250 251 +1
Lines 8705 8778 +73
==========================================
+ Hits 7221 7378 +157
+ Misses 1484 1400 -84
|
cijothomas
reviewed
Nov 28, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
alanwest
reviewed
Nov 29, 2021
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpTraceExporterHelperExtensions.cs
Outdated
Show resolved
Hide resolved
alanwest
approved these changes
Nov 29, 2021
Member
alanwest
left a comment
There was a problem hiding this comment.
LGTM. Haven't thought it through, but this may actually be of use to the gRPC based exporters as well. At least for compilation that uses the Grpc.Net.Client library, you can set the underlying HttpClient to use. Allows for more sophisticated configuration of the channel. https://grpc.github.io/grpc/csharp-dotnet/api/Grpc.Net.Client.GrpcChannelOptions.html#Grpc_Net_Client_GrpcChannelOptions_HttpClient
cijothomas
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2522
Changes
HttpClientFactoryoption we have onJaegerExporterOptions&ZipkinExporterOptionstoOtlpExporterOptions.IHttpClientFactoryintegration whenIDeferredTracerProviderBuilder/IDeferredMeterProviderBuilderis used.HttpProtobufprotocol inOtlpMetricExporter.TODOs
CHANGELOG.mdupdated for non-trivial changes