Publicize required methods to allow for custom implementations of resource detectors.#2949
Merged
cijothomas merged 20 commits intoopen-telemetry:mainfrom Mar 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2949 +/- ##
==========================================
+ Coverage 83.99% 84.02% +0.03%
==========================================
Files 254 254
Lines 8946 8946
==========================================
+ Hits 7514 7517 +3
+ Misses 1432 1429 -3
|
reyang
reviewed
Feb 25, 2022
reyang
reviewed
Feb 25, 2022
reyang
reviewed
Feb 25, 2022
reyang
reviewed
Feb 25, 2022
cijothomas
reviewed
Feb 25, 2022
cijothomas
requested changes
Feb 25, 2022
Yun-Ting
changed the title
cijothomas
reviewed
Mar 1, 2022
cijothomas
reviewed
Mar 1, 2022
cijothomas
approved these changes
Mar 1, 2022
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
Will wait to get one more approval before merge, as this is adding new public API very close to a stable release, and want to get one more review.
reyang
reviewed
Mar 1, 2022
| using var tracerProvider = Sdk.CreateTracerProviderBuilder() | ||
| .SetSampler(new MySampler()) | ||
| .AddSource("OTel.Demo") | ||
| .SetResourceBuilder(ResourceBuilder.CreateEmpty().AddDetector(new MyResourceDetector())) |
Member
There was a problem hiding this comment.
Not directly related to this PR, this line seems complex, maybe it could be simplified to ResourceBuilder.AddDetector(new MyResourceDetector())? (by tweaking the static method)
reyang
reviewed
Mar 1, 2022
Co-authored-by: Reiley Yang <reyang@microsoft.com>
alanwest
reviewed
Mar 1, 2022
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
…/opentelemetry-dotnet into yunl/ResourceDetectorEx
mic-max
approved these changes
Mar 2, 2022
cijothomas
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Addressed #2897 (comment)
#2897 alone itself was not sufficient for the users to implement their own resource detector. And this PR bridge this gap.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes