-
Notifications
You must be signed in to change notification settings - Fork 863
improve test coverage: InMemoryExporter SnapshotMetric #3344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cijothomas
merged 11 commits into
open-telemetry:main
from
TimothyMothra:testcoverage_SnapshotMetric
Jun 17, 2022
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d2eb478
initial commit
db94a86
Merge branch 'main' into testcoverage_SnapshotMetric
d86b1ac
Merge branch 'main' into testcoverage_SnapshotMetric
cijothomas 7fb697f
add additional tests
599624b
Merge branch 'testcoverage_SnapshotMetric' of https://github.com/Timo…
870acaa
Merge branch 'main' into testcoverage_SnapshotMetric
29d156f
Merge branch 'main' into testcoverage_SnapshotMetric
949603a
Merge branch 'main' into testcoverage_SnapshotMetric
cijothomas 8be9d2a
Merge branch 'main' into testcoverage_SnapshotMetric
cijothomas b45dcaa
Merge branch 'main' into testcoverage_SnapshotMetric
cijothomas 00f4671
Merge branch 'main' into testcoverage_SnapshotMetric
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
initial commit
- Loading branch information
There are no files selected for viewing
112 changes: 112 additions & 0 deletions
112
test/OpenTelemetry.Tests/Metrics/MetricSnapshotTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| // <copyright file="MetricSnapshotTests.cs" company="OpenTelemetry Authors"> | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // </copyright> | ||
|
|
||
| using System.Collections.Generic; | ||
| using System.Diagnostics.Metrics; | ||
|
|
||
| using OpenTelemetry.Tests; | ||
|
|
||
| using Xunit; | ||
|
|
||
| namespace OpenTelemetry.Metrics.Tests | ||
| { | ||
| public class MetricSnapshotTests | ||
| { | ||
| [Fact] | ||
| public void VerifySnapshot_Counter() | ||
| { | ||
| var exportedMetrics = new List<Metric>(); | ||
| var exportedSnapshots = new List<MetricSnapshot>(); | ||
|
|
||
| using var meter = new Meter(Utils.GetCurrentMethodName()); | ||
| using var meterProvider = Sdk.CreateMeterProviderBuilder() | ||
| .AddMeter(meter.Name) | ||
| .AddInMemoryExporter(exportedMetrics) | ||
| .AddInMemoryExporter(exportedSnapshots) | ||
| .Build(); | ||
|
|
||
| var counter = meter.CreateCounter<long>("meter"); | ||
| counter.Add(10); | ||
|
|
||
| meterProvider.ForceFlush(); | ||
|
|
||
| // Verify Metric | ||
| Assert.Single(exportedMetrics); | ||
| var metric1 = exportedMetrics[0]; | ||
| var metricPointsEnumerator = metric1.GetMetricPoints().GetEnumerator(); | ||
| Assert.True(metricPointsEnumerator.MoveNext()); | ||
| ref readonly var metricPointForFirstExport = ref metricPointsEnumerator.Current; | ||
| Assert.Equal(10, metricPointForFirstExport.GetSumLong()); | ||
|
|
||
| // Verify Snapshot | ||
| Assert.Single(exportedSnapshots); | ||
| var snapshot1 = exportedSnapshots[0]; | ||
| Assert.Single(snapshot1.MetricPoints); | ||
| Assert.Equal(10, snapshot1.MetricPoints[0].GetSumLong()); | ||
|
|
||
| // Verify Metric == Snapshot | ||
| Assert.Equal(metric1.Name, snapshot1.Name); | ||
| Assert.Equal(metric1.Description, snapshot1.Description); | ||
| Assert.Equal(metric1.Unit, snapshot1.Unit); | ||
| Assert.Equal(metric1.MeterName, snapshot1.MeterName); | ||
| Assert.Equal(metric1.MetricType, snapshot1.MetricType); | ||
| Assert.Equal(metric1.MeterVersion, snapshot1.MeterVersion); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void VerifySnapshot_Histogram() | ||
| { | ||
| var exportedMetrics = new List<Metric>(); | ||
| var exportedSnapshots = new List<MetricSnapshot>(); | ||
|
|
||
| using var meter = new Meter(Utils.GetCurrentMethodName()); | ||
| using var meterProvider = Sdk.CreateMeterProviderBuilder() | ||
| .AddMeter(meter.Name) | ||
| .AddInMemoryExporter(exportedMetrics) | ||
| .AddInMemoryExporter(exportedSnapshots) | ||
| .Build(); | ||
|
|
||
| var histogram = meter.CreateHistogram<int>("histogram"); | ||
| histogram.Record(10); | ||
|
|
||
| meterProvider.ForceFlush(); | ||
|
|
||
| // Verify Metric | ||
| Assert.Single(exportedMetrics); | ||
| var metric1 = exportedMetrics[0]; | ||
| var metricPointsEnumerator = metric1.GetMetricPoints().GetEnumerator(); | ||
| Assert.True(metricPointsEnumerator.MoveNext()); | ||
| ref readonly var metricPointForFirstExport = ref metricPointsEnumerator.Current; | ||
| Assert.Equal(1, metricPointForFirstExport.GetHistogramCount()); | ||
| Assert.Equal(10, metricPointForFirstExport.GetHistogramSum()); | ||
|
|
||
| // Verify Snapshot | ||
| Assert.Single(exportedSnapshots); | ||
| var snapshot1 = exportedSnapshots[0]; | ||
| Assert.Single(snapshot1.MetricPoints); | ||
| Assert.Equal(1, snapshot1.MetricPoints[0].GetHistogramCount()); | ||
| Assert.Equal(10, snapshot1.MetricPoints[0].GetHistogramSum()); | ||
|
|
||
| // Verify Metric == Snapshot | ||
| Assert.Equal(metric1.Name, snapshot1.Name); | ||
| Assert.Equal(metric1.Description, snapshot1.Description); | ||
| Assert.Equal(metric1.Unit, snapshot1.Unit); | ||
| Assert.Equal(metric1.MeterName, snapshot1.MeterName); | ||
| Assert.Equal(metric1.MetricType, snapshot1.MetricType); | ||
| Assert.Equal(metric1.MeterVersion, snapshot1.MeterVersion); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.