Skip to content

SDK: Forward SetParentProvider to children of CompositeProcessor #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 5 commits into from
Jun 16, 2022
+57 −7
Merged

SDK: Forward SetParentProvider to children of CompositeProcessor #3368

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdc7106
Forward SetParentProvider to children of CompositeProcessor.
CodeBlanch Jun 15, 2022
4b88dbe
CHANGELOG update.
CodeBlanch Jun 15, 2022
84cfe78
Test.
CodeBlanch Jun 15, 2022
8b29b34
Test tweak + typo.
CodeBlanch Jun 15, 2022
e9e4379
Fixed automatically created CompositeProcessor missing ParentProvider.
CodeBlanch Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Jun 15, 2022
commit 84cfe78aeff935d0d1a87fbeef8caae7b22c0b87
23 changes: 23 additions & 0 deletions test/OpenTelemetry.Tests/Trace/CompositeActivityProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,5 +99,28 @@ public void CompositeActivityProcessor_ForceFlush(int timeout)
Assert.True(p1.ForceFlushCalled);
Assert.True(p2.ForceFlushCalled);
}

[Fact]
public void CompositeActivityProcessor_ForwardsParentProviderl()
{
using TracerProvider provider = new TestProvider();

using var p1 = new TestActivityProcessor(null, null);
using var p2 = new TestActivityProcessor(null, null);

using var processor = new CompositeProcessor<Activity>(new[] { p1, p2 });

Assert.Null(p1.ParentProvider);
Assert.Null(p2.ParentProvider);

processor.SetParentProvider(provider);

Assert.Equal(provider, p1.ParentProvider);
Assert.Equal(provider, p2.ParentProvider);
}

private sealed class TestProvider : TracerProvider
{
}
}
}