Add http.scheme tag to HttpClient instrumentation#3464
Merged
utpilla merged 4 commits intoopen-telemetry:mainfrom Jul 20, 2022
Merged
Add http.scheme tag to HttpClient instrumentation#3464utpilla merged 4 commits intoopen-telemetry:mainfrom
utpilla merged 4 commits intoopen-telemetry:mainfrom
Conversation
added 2 commits
July 20, 2022 11:04
alanwest
approved these changes
Jul 20, 2022
reyang
approved these changes
Jul 20, 2022
Kielek
approved these changes
Jul 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #3464 +/- ##
==========================================
- Coverage 86.35% 86.34% -0.02%
==========================================
Files 267 267
Lines 9633 9634 +1
==========================================
- Hits 8319 8318 -1
- Misses 1314 1316 +2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #.
part of #3373
Changes
Adding
http.schemefor HttpClient tracing instrumentation. The tag already exists for metrics part and is recommended according to spec.Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes