Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
9f35527
fix
Jul 27, 2022
1431a4b
update changelog
Jul 27, 2022
69d05aa
remove httpfeature
Jul 27, 2022
19871ed
remove un-necessary using
Jul 27, 2022
22aaa69
comment fix
Jul 27, 2022
1367b7f
Merge branch 'main' into vibankwa/follow-up-3490
vishweshbankwar Jul 27, 2022
9fd51ac
remove custom context extraction
Jul 28, 2022
d54c706
Merge branch 'vibankwa/follow-up-3490' of https://github.com/vishwesh…
Jul 28, 2022
7904859
resolve PR comments
Jul 29, 2022
9995266
update comment
Jul 29, 2022
5081a42
rmv using
Jul 29, 2022
5d3d4f7
Merge branch 'main' into vibankwa/follow-up-3490
Jul 29, 2022
1346d51
Merge branch 'main' into vibankwa/follow-up-3490
cijothomas Jul 30, 2022
2e40541
update comment
vishweshbankwar Aug 1, 2022
fa4563c
Merge branch 'main' into vibankwa/follow-up-3490
vishweshbankwar Aug 1, 2022
7efff96
Merge branch 'main' into vibankwa/follow-up-3490
vishweshbankwar Aug 1, 2022
f4f8e15
Merge branch 'main' into vibankwa/follow-up-3490
Aug 3, 2022
7bae1f9
Merge branch 'vibankwa/follow-up-3490' of https://github.com/vishwesh…
Aug 3, 2022
b835e9c
Merge branch 'main' into vibankwa/follow-up-3490
vishweshbankwar Aug 3, 2022
f23e8ac
Merge branch 'main' into vibankwa/follow-up-3490
cijothomas Aug 5, 2022
daf6f7c
Merge branch 'main' into vibankwa/follow-up-3490
vishweshbankwar Aug 9, 2022
bf276e2
Merge branch 'main' into vibankwa/follow-up-3490
Aug 9, 2022
e16afe0
Merge branch 'vibankwa/follow-up-3490' of https://github.com/vishwesh…
Aug 9, 2022
eebe6d8
refactor test
Aug 9, 2022
427bd0b
Merge branch 'main' into vibankwa/follow-up-3490
vishweshbankwar Aug 9, 2022
5971b8d
Merge branch 'main' into vibankwa/follow-up-3490
Aug 11, 2022
edc2497
Merge branch 'vibankwa/follow-up-3490' of https://github.com/vishwesh…
Aug 11, 2022
730deae
add comment
Aug 11, 2022
5038cc9
fix space
Aug 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
  • Loading branch information
vishweshbankwar and cijothomas authored Aug 1, 2022
commit 2e40541f652f1cef5c5b78c95233c0d79bcdd777
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public override void OnCustom(string name, Activity activity, object payload)
// We cannot rely on Activity.Current here
// There could be activities started by middleware
// after activity started by framework resulting in different Activity.Current.
// so, we need to first find the activity started by framework.
// so, we need to first find the activity started by Asp.Net Core.
// For .net6.0 onwards we could use IHttpActivityFeature to get the activity created by framework
// var httpActivityFeature = context.Features.Get<IHttpActivityFeature>();
// activity = httpActivityFeature.Activity;
Expand Down