[Instrumentation.Http] Change Activity Source Name for HttpWebRequest…#3515
Merged
cijothomas merged 7 commits intoopen-telemetry:mainfrom Aug 5, 2022
Merged
Conversation
…s from OpenTelemetry.HttpWebRequest to OpenTelemetry.Instrumentation.HttpWebRequest
Kielek
force-pushed
the
activitysorucename-httpwebrequest-v2
branch
from
3760565 to
db79dba
Compare
1 task
Codecov Report
@@ Coverage Diff @@
## main #3515 +/- ##
==========================================
- Coverage 87.16% 87.11% -0.06%
==========================================
Files 275 275
Lines 9959 9959
==========================================
- Hits 8681 8676 -5
- Misses 1278 1283 +5
|
alanwest
reviewed
Aug 2, 2022
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Aug 4, 2022
utpilla
approved these changes
Aug 4, 2022
vishweshbankwar
approved these changes
Aug 4, 2022
Contributor
|
Please resolve the merge conflicts. |
cijothomas
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative PR to #3509
Changes
[Instrumentation.Http] Change Activity Source Name for
HttpWebRequests fromOpenTelemetry.HttpWebRequesttoOpenTelemetry.Instrumentation.HttpWebRequest.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes[ ] Design discussion issue #[ ] Changes in public API reviewed