Skip to content

Conversation

@CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 14, 2022

Changes

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Unit tests
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 14, 2022 19:28
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3661 (764f55f) into main (ef46e82) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3661      +/-   ##
==========================================
+ Coverage   87.61%   87.62%   +0.01%     
==========================================
  Files         283      283              
  Lines       10270    10273       +3     
==========================================
+ Hits         8998     9002       +4     
+ Misses       1272     1271       -1     
Impacted Files Coverage Δ
...tion.AspNetCore/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-2.95%) ⬇️
src/OpenTelemetry/Logs/OpenTelemetryLogger.cs 86.66% <0.00%> (-2.23%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.05% <0.00%> (-1.10%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 74.72% <0.00%> (+2.19%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 100.00% <0.00%> (+12.50%) ⬆️

@CodeBlanch CodeBlanch merged commit 97e5021 into open-telemetry:main Sep 14, 2022
@CodeBlanch CodeBlanch deleted the aspnetcore-namedoptions branch September 14, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants