Skip to content

Guard.Range now uses invariant culture for error message #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 2 commits into from
Oct 21, 2022
Merged

Guard.Range now uses invariant culture for error message #3778

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6835e8f
Guard.Range now uses invariant culture for error message
Driedas Oct 18, 2022
4c60de0
Merge branch 'main' into main
utpilla Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/OpenTelemetry.Api/Internal/Guard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

using System;
using System.Diagnostics;
using System.Globalization;
using System.Runtime.CompilerServices;
using System.Threading;

Expand Down Expand Up @@ -198,7 +199,13 @@ private static void Range<T>(T value, string? paramName, T min, T max, string? m
{
var minMessage = minName != null ? $": {minName}" : string.Empty;
var maxMessage = maxName != null ? $": {maxName}" : string.Empty;
var exMessage = message ?? $"Must be in the range: [{min}{minMessage}, {max}{maxMessage}]";
var exMessage = message ?? string.Format(
CultureInfo.InvariantCulture,
"Must be in the range: [{0}{1}, {2}{3}]",
min,
minMessage,
max,
maxMessage);
throw new ArgumentOutOfRangeException(paramName, value, exMessage);
}
}
Expand Down