Skip to content

[SDK] Add some missing nullable annotations #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 8 commits into from
Oct 21, 2022
Merged

[SDK] Add some missing nullable annotations #3796

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72e22dc
Added some missing nullable annotations in SDK.
CodeBlanch Oct 20, 2022
2673b05
Handle null span names in SamplingParameters.
CodeBlanch Oct 20, 2022
5fe2a4b
Warning cleanup.
CodeBlanch Oct 20, 2022
4a52152
Merge branch 'main' into sdk-nullable-annotations
alanwest Oct 21, 2022
5f2ff1d
Warning cleanup.
CodeBlanch Oct 21, 2022
cd865e0
Merge branch 'main' into sdk-nullable-annotations
CodeBlanch Oct 21, 2022
92700d7
Added link to issue in comment.
CodeBlanch Oct 21, 2022
09d7a73
Merge branch 'sdk-nullable-annotations' of https://github.com/CodeBla…
CodeBlanch Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added link to issue in comment.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Oct 21, 2022
commit 92700d7c9e0fbf74d6b6f53c81beee209717b8a0
3 changes: 2 additions & 1 deletion src/OpenTelemetry/Trace/SamplingParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ public SamplingParameters(
this.Links = links;

// Note: myActivitySource.StartActivity(name: null) is currently
// allowed even though OTel spec says span name is required.
// allowed even though OTel spec says span name is required. See:
// https://github.com/open-telemetry/opentelemetry-dotnet/issues/3802
this.Name = name ?? string.Empty;
}

Expand Down