Skip to content

[sdk] Use reflection and dynamic types to start providers #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanwest merged 17 commits into from
Feb 8, 2023
Merged

[sdk] Use reflection and dynamic types to start providers #4151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d879a29
Remove StartWithHost extension and using reflection to do the work in…
CodeBlanch Feb 6, 2023
7716560
Warning cleanup.
CodeBlanch Feb 7, 2023
acb39c2
Fix up.
CodeBlanch Feb 7, 2023
1d5df25
Improved logging.
CodeBlanch Feb 7, 2023
54eef54
Remove OpenTelemetry.Extensions.Hosting dependency from examples & docs.
CodeBlanch Feb 7, 2023
c66f283
Test fixes.
CodeBlanch Feb 7, 2023
c088a9d
Fixes and test updates.
CodeBlanch Feb 7, 2023
c29470e
Bug fix.
CodeBlanch Feb 7, 2023
0cd2c59
Patch CHANGELOGs.
CodeBlanch Feb 7, 2023
7a5036f
Clean up.
CodeBlanch Feb 7, 2023
a7d289e
Merge from main.
CodeBlanch Feb 7, 2023
1591396
Merge branch 'main' into sdk-hosting
cijothomas Feb 8, 2023
7be35d7
Support Azure Functions TelemetryHostedService dependency inspection …
CodeBlanch Feb 8, 2023
a7e9608
Merge branch 'sdk-hosting' of https://github.com/CodeBlanch/opentelem…
CodeBlanch Feb 8, 2023
f368c21
Code review.
CodeBlanch Feb 8, 2023
b340749
Code review.
CodeBlanch Feb 8, 2023
dd2f8c3
Code review.
CodeBlanch Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Warning cleanup.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Feb 7, 2023
commit 77165602ca01550f8aabb70dcc21815e44ee43b5
1 change: 0 additions & 1 deletion src/OpenTelemetry.Extensions.Hosting/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions
OpenTelemetry.Metrics.MeterProviderBuilderExtensions
OpenTelemetry.OpenTelemetryBuilderHostingExtensions
OpenTelemetry.Trace.TracerProviderBuilderExtensions
static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryMetrics(this Microsoft.Extensions.DependencyInjection.IServiceCollection services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryMetrics(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, System.Action<OpenTelemetry.Metrics.MeterProviderBuilder> configure) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
Expand Down
2 changes: 1 addition & 1 deletion src/OpenTelemetry/Internal/HostingHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public TelemetryHostedService(IServiceProvider serviceProvider)
{
Debug.Assert(serviceProvider != null, "serviceProvider was null");

this.serviceProvider = serviceProvider;
this.serviceProvider = serviceProvider!;
}

public void Start()
Expand Down