Skip to content

[AspNetCore] Avoid boxing of status code tags #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 4 commits into from
Apr 4, 2023
Merged

[AspNetCore] Avoid boxing of status code tags #4360

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0bf5613
Avoid boxing of status code tags.
CodeBlanch Apr 4, 2023
f8abba6
CHANGELOG patch.
CodeBlanch Apr 4, 2023
cf8e256
StyleCop warning suppression.
CodeBlanch Apr 4, 2023
0fe5fdf
Merge branch 'main' into aspnetcore-statuscode-boxing
CodeBlanch Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
StyleCop warning suppression.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Apr 4, 2023
commit cf8e256ace5967090f8164ab6d07d590ffc5e0ac
2 changes: 2 additions & 0 deletions src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/TelemetryHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation;

internal static class TelemetryHelper
{
#pragma warning disable SA1509 // Opening braces should not be preceded by blank line
// Status Codes listed at http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
private static readonly Dictionary<int, object> BoxedStatusCodes = new()
{
Expand Down Expand Up @@ -89,6 +90,7 @@ internal static class TelemetryHelper
{ 510, 510 },
{ 511, 511 },
};
#pragma warning restore SA1509 // Opening braces should not be preceded by blank line

public static object GetBoxedStatusCode(int statusCode)
{
Expand Down