Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Obsolete OtlpExporterOptions.ExportProcessorType and BatchExportProce…
…ssorOptions
  • Loading branch information
alanwest committed Apr 21, 2023
commit a9edbf4f7446add958de1a8f4b095f17063ce348
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,13 @@ public Uri Endpoint
/// <summary>
/// Gets or sets the export processor type to be used with the OpenTelemetry Protocol Exporter. The default value is <see cref="ExportProcessorType.Batch"/>.
/// </summary>
[Obsolete("Use ActivityExportProcessorOptions or LogRecordExportProcessorOptions.")]
public ExportProcessorType ExportProcessorType { get; set; } = ExportProcessorType.Batch;

/// <summary>
/// Gets or sets the BatchExportProcessor options. Ignored unless ExportProcessorType is Batch.
/// </summary>
[Obsolete("Use ActivityExportProcessorOptions or LogRecordExportProcessorOptions.")]
public BatchExportProcessorOptions<Activity> BatchExportProcessorOptions { get; set; }

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ internal static BaseProcessor<Activity> BuildOtlpExporterProcessor(
otlpExporter = configureExporterInstance(otlpExporter);
}

// TODO: exporterOptions.ExportProcessorType and exporterOptions.BatchExportProcessorOptions are obsolete.
// This needs to be adapted to use honor the obsolete settings as well as the new
// ActivityExportProcessorOptions.
if (exporterOptions.ExportProcessorType == ExportProcessorType.Simple)
{
return new SimpleActivityExportProcessor(otlpExporter);
Expand Down