[hosting-logs] Don't register ILogger when calling WithLogging #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
CodeBlanch
changed the title
alanwest
approved these changes
Jun 1, 2023
Member
alanwest
left a comment
alanwest
left a comment
There was a problem hiding this comment.
LGTM
Just elaborating on our reasoning a bit more to remind my future self...
Having WithLogging have the side effect of turning on ILogger support may be undesirable to some users. For example, maybe a user is using EventSource and ILogger in their application and they only want EventSource integrated with OTel - enabling ILogger in WithLogging prevents this scenario. This scenario may seem unlikely, but I do not see a strong reason to prevent it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4535 +/- ##
==========================================
+ Coverage 85.57% 85.60% +0.03%
==========================================
Files 320 320
Lines 12611 12610 -1
==========================================
+ Hits 10792 10795 +3
+ Misses 1819 1815 -4
|
mfogliatto
pushed a commit
to mfogliatto/opentelemetry-dotnet
that referenced
this pull request
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Changes
ILoggerProviderwhen callingWithLoggingDetails
@alanwest and I felt like this behavior needed more discussion.
Merge requirement checklist