update HttpSemanticConventions for Instrumentation.Http

[TimothyMothra]

Design discussion issue #4484

Changes

• add new attributes to SemanticConventions
• update Instrumentation.Http classes HttpHandlerDiagnosticListener and HttpHandlerMetricsDiagnosticListener to emit new attributes
  • http.scheme -> url.scheme
  • http.method -> http.request.method
  • net.peer.name -> server.address
  • net.peer.port -> server.port
  • http.url -> url.full
  • http.flavor -> network.protocol.version
  • http.status_code -> http.response.status_code

Please provide a brief description of the changes here.

Merge requirement checklist

• CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

@vishweshbankwar please review

[vishweshbankwar]

FYI - we will also need to update this https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs (separate PR)

[TimothyMothra]

FYI - we will also need to update this https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpWebRequestActivitySource.netfx.cs (separate PR)

Sorry, I missed it because I was only looking at the "Listener" classes.
Any reason to not include it in this PR?

[codecov]

Codecov Report

Merging #4538 (a3d4a9a) into main (938bc5c) will decrease coverage by 0.13%.
The diff coverage is 52.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4538      +/-   ##
==========================================
- Coverage   85.04%   84.91%   -0.13%     
==========================================
  Files         313      313              
  Lines       12575    12601      +26     
==========================================
+ Hits        10694    10700       +6     
- Misses       1881     1901      +20     

Impacted Files	Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs	67.54% <50.00%> (-6.95%)	⬇️
...ementation/HttpHandlerMetricsDiagnosticListener.cs	71.87% <55.55%> (-23.58%)	⬇️

... and 4 files with indirect coverage changes

[vishweshbankwar]

LGTM: Need changelog entry

[utpilla]

This would cause an allocation. Refer to how AspNetCore instrumentation handles this: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs#L217-L224

This should be done in a separate PR which updates the benchmarks as well.

[utpilla]

Left a comment about updating the urls to point to a commit/tag instead of main branch.

Need a CHANGELOG entry.

[reyang]

What does this mean?

[TimothyMothra]

I was asked to separate the new attributes from the others and give it a descriptive comment.
The word "new" isn't needed here, sorry for the confusion.
I've updated this comment in the AspNetCore PR but forgot to update it here.

[reyang]

I was asked to separate the new attributes from the others and give it a descriptive comment.

What does v1.21.0 mean?

The word "new" isn't needed here

👍

[reyang]

FYI - v1.21.0 doesn't contain semantic convention changes https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/CHANGELOG.md#v1210-2023-05-09

[TimothyMothra]

The semantic-conventions repo doesn't have any tags yet so I can't link to a versioned copy of the Http document.

I discussed this with Utkarsh last week and he suggested using the v1.21.0 tag on the opentelemetry-specification repo.
The opentelemetry-specification repo does have tags and that version of the document does include all of the new attributes that we're adding in this PR.