Skip to content

[otlp] Remove ilogger and exception attributes #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utpilla merged 12 commits into from
Aug 21, 2023
Merged

[otlp] Remove ilogger and exception attributes #4781

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
87980ac
Temporarily remove ilogger and ex attributes
Aug 17, 2023
65aa7ef
add changelog
Aug 17, 2023
619d2bd
Update CHANGELOG.md
vishweshbankwar Aug 17, 2023
e5c892f
format
Aug 17, 2023
83ea7fe
Merge branch 'vibankwa/remove-experimental-attributes' of https://git…
Aug 17, 2023
6ca7e06
rmv using
Aug 17, 2023
3325b40
format
Aug 17, 2023
79295b4
format test
Aug 17, 2023
576429c
pr feedback
Aug 18, 2023
e6b314c
address feedback
Aug 18, 2023
1fbc66d
addres feedback
Aug 21, 2023
559f26f
Merge branch 'main' into vibankwa/remove-experimental-attributes
vishweshbankwar Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md
  • Loading branch information
@vishweshbankwar
vishweshbankwar authored Aug 17, 2023
commit 619d2bd6dfb95aa5385ebbd149dd4b0c9f377bf0
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

* Excluded attributes corresponding to `LogRecord.EventId`,
Copy link
Member

@cijothomas cijothomas Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its better if we add a stronger message here, as this is a significant breaking change for users who are relying on these features.

Breaking/Please Note or something to catch attention.

Copy link

@samsp-msft samsp-msft Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having the EventId & Category properties makes it harder to filter log messages to the ones that you care about. They could go in the attributes as they are SDK specific.

Copy link

@amccool amccool Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having the EventId & Category properties makes it harder to filter log messages to the ones that you care about. They could go in the attributes as they are SDK specific.

+1

Copy link

@austindrenski austindrenski Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having the EventId & Category properties makes it harder to filter log messages to the ones that you care about. They could go in the attributes as they are SDK specific.

Indeed. Missed this in last week's release notes and ran into this today. Was a real head-scratcher for a few hours because this is the last place I expected these (fairly ubiquitous) dotnet attrs to be getting dropped ☹️

`LogRecord.CategoryName` and `LogRecord.Exception` from the exported data. This
is done in order to move ahead with stable release of exporter. THe attributes
is done in order to move ahead with stable release of exporter. The attributes
will be brought back in the pre-release version post stable release.
([#4781](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4781))

Expand Down