Increase the character limit of the Meter instrument name#4798
Merged
utpilla merged 2 commits intoopen-telemetry:mainfrom Aug 23, 2023
Merged
Increase the character limit of the Meter instrument name#4798utpilla merged 2 commits intoopen-telemetry:mainfrom
utpilla merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
- Coverage 85.60% 85.58% -0.02%
==========================================
Files 284 284
Lines 11686 11686
==========================================
- Hits 10004 10002 -2
- Misses 1682 1684 +2
|
cijothomas
approved these changes
Aug 23, 2023
Member
cijothomas
left a comment
There was a problem hiding this comment.
Thanks! LGTM. Please add an entry to changelog.md file as this is user facing change.
Yun-Ting
reviewed
Aug 23, 2023
Contributor
Yun-Ting
left a comment
There was a problem hiding this comment.
Just saw a typo from the PR description:
"Changed the limit of the instrument name regex from 63 to 244 as specified"
should be 254 instead of 244.
reyang
approved these changes
Aug 23, 2023
utpilla
approved these changes
Aug 23, 2023
Contributor
Author
@Yun-Ting Thanks. I adjusted the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design discussion issue #4774
Changes
Changed the limit of the instrument name regex from 63 to 255 as specified here in the Open Telemetry metrics API specification.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes