-
Notifications
You must be signed in to change notification settings - Fork 862
OTLP LogExporter limits configuration by env. var. #4887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP LogExporter limits configuration by env. var. #4887
Conversation
f459b4c to
fb20faa
Compare
Codecov Report
@@ Coverage Diff @@
## main #4887 +/- ##
==========================================
+ Coverage 82.91% 83.06% +0.14%
==========================================
Files 294 294
Lines 12188 12198 +10
==========================================
+ Hits 10106 10132 +26
+ Misses 2082 2066 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/LogRecordExtensions.cs
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/SdkLimitOptions.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CodeBlanch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4156
Changes
Added support for
OTEL_LOGRECORD_ATTRIBUTE_VALUE_LENGTH_LIMITand
OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMIT.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)