update examples to support net8.0

open-telemetry · utpilla · Oct 6, 2023 · Sep 29, 2023 · Sep 29, 2023 · Sep 29, 2023
commit 621839c97dc1490c43d38b2beddeb2dfd90c7ef3
diff --git a/docs/Directory.Build.props b/docs/Directory.Build.props
@@ -5,7 +5,7 @@
     <OutputType>Exe</OutputType>
     <!-- https://dotnet.microsoft.com/download/dotnet-core -->
     <!-- OmniSharp/VS Code requires TargetFrameworks to be in descending order for IntelliSense and analysis. -->
-    <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
     <!-- https://dotnet.microsoft.com/download/dotnet-framework -->
     <TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462;net47;net471;net472;net48</TargetFrameworks>
   </PropertyGroup>

diff --git a/docs/Directory.Packages.props b/docs/Directory.Packages.props
@@ -1,6 +1,6 @@
 <Project>
   <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Packages.props, $(MSBuildThisFileDirectory)..))" />
   <ItemGroup>
-    <PackageVersion Update="Microsoft.Extensions.Logging" Version="[6.0.0,)" />
+    <PackageVersion Update="Microsoft.Extensions.Logging" Version="[8.0.0-rc.1.23419.4,)" />
   </ItemGroup>
 </Project>
@@ -56,9 +56,9 @@
 
 public static partial class ApplicationLogs
 {
-    [LoggerMessage(EventId = 1, Level = LogLevel.Information, Message = "Starting the app...")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Starting the app...")]
     public static partial void StartingApp(this ILogger logger);
 
-    [LoggerMessage(EventId = 2, Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
     public static partial void FoodPriceChanged(this ILogger logger, string name, double price);
 }
@@ -35,7 +35,7 @@ LogRecord.SeverityText:            Information
 LogRecord.Body:                    Starting the app...
 LogRecord.Attributes (Key:Value):
     OriginalFormat (a.k.a Body): Starting the app...
-LogRecord.EventId:                 1
+LogRecord.EventId:                 225744744
 LogRecord.EventName:               StartingApp
 
 ...
@@ -65,7 +65,7 @@ LogRecord.Attributes (Key:Value):
     name: artichoke
     price: 9.99
     OriginalFormat (a.k.a Body): Food `{name}` price changed to `{price}`.
-LogRecord.EventId:                 2
+LogRecord.EventId:                 344095174
 LogRecord.EventName:               FoodPriceChanged
 
 ...
@@ -110,10 +110,10 @@ logging, and type-checked parameters:
 ```csharp
 public static partial class ApplicationLogs
 {
-    [LoggerMessage(EventId = 1, Level = LogLevel.Information, Message = "Starting the app...")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Starting the app...")]
     public static partial void StartingApp(this ILogger logger);
 
-    [LoggerMessage(EventId = 2, Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
     public static partial void FoodPriceChanged(this ILogger logger, string name, double price);
 }
 ```
@@ -125,18 +125,6 @@ generic `ILogger<T>` is not an option, `app.Logger` is used instead:
 app.Logger.StartingApp();
 ```
 
-> **Note**
-> There are cases where logging is needed before the [dependency injection
-(DI)](https://learn.microsoft.com/dotnet/core/extensions/dependency-injection)
-logging pipeline is available (e.g. before `builder.Build()`) or after the DI
-logging pipeline is disposed (e.g. after `app.Run()`). The common practice is to
-use a separate logging pipeline by creating a `LoggerFactory` instance.
->
-> Refer to the [Getting Started with OpenTelemetry .NET Logs in 5 Minutes -
-Console Application](../getting-started-console/README.md) tutorial to learn
-more about how to create a `LoggerFactory` instance and configure OpenTelemetry
-to work with it.
-
 ## Learn more
 
 * [Compile-time logging source

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

@@ -43,10 +43,10 @@
 
 public static partial class ApplicationLogs
 {
-    [LoggerMessage(EventId = 1, Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
     public static partial void FoodPriceChanged(this ILogger logger, string name, double price);
 
-    [LoggerMessage(EventId = 2, Message = "A `{productType}` recall notice was published for `{brandName} {productDescription}` produced by `{companyName}` ({recallReasonDescription}).")]
+    [LoggerMessage(Message = "A `{productType}` recall notice was published for `{brandName} {productDescription}` produced by `{companyName}` ({recallReasonDescription}).")]
     public static partial void FoodRecallNotice(
         this ILogger logger,
         LogLevel logLevel,

@@ -43,7 +43,7 @@ LogRecord.Attributes (Key:Value):
     name: artichoke
     price: 9.99
     OriginalFormat (a.k.a Body): Food `{name}` price changed to `{price}`.
-LogRecord.EventId:                 1
+LogRecord.EventId:                 344095174
 LogRecord.EventName:               FoodPriceChanged
 
 ...
@@ -60,7 +60,7 @@ LogRecord.Attributes (Key:Value):
     recallReasonDescription: due to a possible health risk from Listeria monocytogenes
     companyName: Contoso Fresh Vegetables, Inc.
     OriginalFormat (a.k.a Body): A `{productType}` recall notice was published for `{brandName} {productDescription}` produced by `{companyName}` ({recallReasonDescription}).
-LogRecord.EventId:                 2
+LogRecord.EventId:                 1338249384
 LogRecord.EventName:               FoodRecallNotice
 
 ...
@@ -93,7 +93,7 @@ logging, and type-checked parameters:
 ```csharp
 public static partial class ApplicationLogs
 {
-    [LoggerMessage(EventId = 1, Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
     public static partial void FoodPriceChanged(this ILogger logger, string name, double price);
 
     ...

@@ -37,6 +37,6 @@
 
 public static partial class ApplicationLogs
 {
-    [LoggerMessage(EventId = 1, Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Food `{name}` price changed to `{price}`.")]
     public static partial void FoodPriceChanged(this ILogger logger, string name, double price);
 }
diff --git a/docs/metrics/getting-started-aspnetcore/getting-started-aspnetcore.csproj b/docs/metrics/getting-started-aspnetcore/getting-started-aspnetcore.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/docs/trace/getting-started-aspnetcore/getting-started-aspnetcore.csproj b/docs/trace/getting-started-aspnetcore/getting-started-aspnetcore.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>