Skip to content

[api] Fix memory leaks in TracerProvider.GetTracer API #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 13 commits into from
Oct 5, 2023
Merged

[api] Fix memory leaks in TracerProvider.GetTracer API #4906

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5725dda
Fix memory leaks in TracerProvider.GetTracer API.
CodeBlanch Sep 29, 2023
0bd778c
Tweak.
CodeBlanch Oct 2, 2023
87a1bbc
Added a test for tracer becoming no-op when parent provider is disposed.
CodeBlanch Oct 3, 2023
31b045f
CHANGELOG patch.
CodeBlanch Oct 3, 2023
8afee1b
Test tweak.
CodeBlanch Oct 3, 2023
6d84dec
Tweak design to avoid any potential breaking changes.
CodeBlanch Oct 3, 2023
5951223
Merge branch 'main' into api-gettracer-memoryleak
CodeBlanch Oct 3, 2023
988af80
Code review.
CodeBlanch Oct 4, 2023
8b4895d
Code review.
CodeBlanch Oct 4, 2023
ca19d28
Switch to ConcurrentDictionary.
CodeBlanch Oct 4, 2023
7c1ec50
Code review.
CodeBlanch Oct 4, 2023
404df8b
Merge branch 'main' into api-gettracer-memoryleak
CodeBlanch Oct 5, 2023
83e550b
Merge branch 'main' into api-gettracer-memoryleak
CodeBlanch Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Oct 4, 2023
commit 8b4895d294c1581108f3dd44b8767e0f31959480
2 changes: 1 addition & 1 deletion test/OpenTelemetry.Api.Tests/Trace/TracerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ public void CreateSpan_NotSampled()
}

[Fact]
public void Tracer_Disposed_Becomes_Noop()
public void TracerBecomesNoopWhenParentProviderIsDisposedTest()
{
TracerProvider provider = null;
Tracer tracer = null;
Expand Down