Add support for .NET8.0 HttpClient metrics#4931
Merged
utpilla merged 22 commits intoopen-telemetry:mainfrom Oct 20, 2023
Merged
Add support for .NET8.0 HttpClient metrics#4931utpilla merged 22 commits intoopen-telemetry:mainfrom
utpilla merged 22 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main open-telemetry/opentelemetry-dotnet#4931 +/- ##
==========================================
+ Coverage 83.26% 83.29% +0.02%
==========================================
Files 295 295
Lines 12375 12378 +3
==========================================
+ Hits 10304 10310 +6
+ Misses 2071 2068 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 4 commits
October 6, 2023 17:55
utpilla
reviewed
Oct 9, 2023
test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 9, 2023
test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 9, 2023
test/OpenTelemetry.Instrumentation.Http.Tests/HttpClientTests.cs
Outdated
Show resolved
Hide resolved
added 2 commits
October 10, 2023 09:13
|
@JamesNK please review |
cijothomas
reviewed
Oct 10, 2023
cijothomas
reviewed
Oct 10, 2023
antonfirsov
reviewed
Oct 10, 2023
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
sshumakov
reviewed
Oct 12, 2023
src/OpenTelemetry.Instrumentation.Http/MeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 17, 2023
utpilla
reviewed
Oct 19, 2023
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerMetricsDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 19, 2023
src/OpenTelemetry.Instrumentation.Http/MeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 19, 2023
src/OpenTelemetry.Instrumentation.Http/MeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Oct 19, 2023
added 4 commits
October 19, 2023 14:29
utpilla
approved these changes
Oct 19, 2023
cijothomas
reviewed
Oct 20, 2023
cijothomas
approved these changes
Oct 20, 2023
Member
cijothomas
left a comment
There was a problem hiding this comment.
Looks good.
Some comments from #4934 (review) are applicable here as well.
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
CodeBlanch
reviewed
Oct 20, 2023
src/OpenTelemetry.Instrumentation.Http/MeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Oct 20, 2023
| #if NETFRAMEWORK | ||
| .Replace("{flavor}", "1.1"); | ||
| #else | ||
| .Replace("{flavor}", "2.0"); |
Member
There was a problem hiding this comment.
This is kind of interesting. How is it we don't report 2.0 now?
CodeBlanch
approved these changes
Oct 20, 2023
Member
CodeBlanch
left a comment
There was a problem hiding this comment.
Some non-blocking feedback, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards open-telemetry/opentelemetry-dotnet-contrib#1753
Details: open-telemetry/opentelemetry-dotnet-contrib#1753
open-telemetry/opentelemetry-dotnet-contrib#1753
Changes
This PR adds support for metrics enablement that are part of
.NET8.0. ForHttpClientthe following meters will be added to the MeterProviderBuilder when application targets.NET8.0framework:Meter :
System.Net.Httphttp.client.request.durationhttp.client.active_requestshttp.client.open_connectionshttp.client.connection.durationhttp.client.request.time_in_queueMeter :
System.Net.NameResolutiondns.lookups.durationUsers may selectively opt-out with the help of views.
TODO: Update Readme
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes