Skip to content

[OTLP] Export LogRecord.CategoryName as InstrumentationScope name #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utpilla merged 14 commits into from
Oct 16, 2023
Merged

[OTLP] Export LogRecord.CategoryName as InstrumentationScope name #4941

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9db7130
draft
Oct 10, 2023
7fdeecb
update test
Oct 11, 2023
221d29c
changelog
Oct 11, 2023
c92aa72
Merge branch 'main' into vibankwa/export-log-category-as-instrumentat…
vishweshbankwar Oct 12, 2023
a233ea7
refactor
Oct 12, 2023
688b1cf
refactor
Oct 12, 2023
5630f11
update comment
Oct 12, 2023
b35f720
address comments
Oct 12, 2023
d7a8a37
refactor
Oct 12, 2023
d050875
Merge branch 'main' into vibankwa/export-log-category-as-instrumentat…
vishweshbankwar Oct 12, 2023
e0ea045
update test
Oct 12, 2023
a3d0424
Merge branch 'vibankwa/export-log-category-as-instrumentationscope' o…
Oct 12, 2023
264b513
Merge branch 'main' into vibankwa/export-log-category-as-instrumentat…
vishweshbankwar Oct 13, 2023
7c2e9c9
Merge branch 'main' into vibankwa/export-log-category-as-instrumentat…
utpilla Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comments
  • Loading branch information
Vishwesh Bankwar committed Oct 12, 2023
commit b35f720ae4389baf94de0ce1e6a3cd6483f5c2b5
4 changes: 1 addition & 3 deletions src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OtlpLogRecordTransformer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ internal OtlpCollector.ExportLogsServiceRequest BuildExportRequest(
OtlpResource.Resource processResource,
in Batch<LogRecord> logRecordBatch)
{
// https://github.com/open-telemetry/opentelemetry-dotnet/issues/4943
// TODO: https://github.com/open-telemetry/opentelemetry-dotnet/issues/4943
Dictionary<string, OtlpLogs.ScopeLogs> logsByCategory = new Dictionary<string, OtlpLogs.ScopeLogs>();

var request = new OtlpCollector.ExportLogsServiceRequest();
Expand All @@ -55,8 +55,6 @@ internal OtlpCollector.ExportLogsServiceRequest BuildExportRequest(
};
request.ResourceLogs.Add(resourceLogs);

logsByCategory.Clear();

foreach (var logRecord in logRecordBatch)
{
var otlpLogRecord = this.ToOtlpLog(logRecord);
Expand Down