Check isSampled parameter in UpdateWithExemplar method #5004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larReservoir!.Offer only when it's true
cijothomas
approved these changes
Oct 28, 2023
Member
|
@ImoutoChan Thanks! Could you add an entry to the changelog file as this is a bug fix? |
Codecov Report
@@ Coverage Diff @@
## main #5004 +/- ##
=======================================
Coverage 83.37% 83.38%
=======================================
Files 295 295
Lines 12339 12343 +4
=======================================
+ Hits 10288 10292 +4
Misses 2051 2051
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
@cijothomas sure |
cijothomas
approved these changes
Oct 30, 2023
utpilla
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4851
Changes
Check isSampled parameter in UpdateWithExemplar method before each call to ExemplarReservoir!.Offer
Merge requirement checklist