Skip to content

Conversation

@ngruson
Copy link
Contributor

@ngruson ngruson commented Nov 10, 2023

See #5040 (comment)

Changes

Be gone, InProcServerTests!

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ngruson ngruson requested a review from a team November 10, 2023 20:15
@codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #5041 (86778af) into main (6637308) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5041      +/-   ##
==========================================
+ Coverage   83.31%   83.33%   +0.01%     
==========================================
  Files         296      296              
  Lines       12475    12475              
==========================================
+ Hits        10394    10396       +2     
+ Misses       2081     2079       -2     
Flag Coverage Δ
unittests 83.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@utpilla utpilla merged commit c062e12 into open-telemetry:main Nov 10, 2023
@ngruson ngruson deleted the remove-inprocservertests branch November 11, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants