Skip to content

Only create a sibling activity when trace id, span id or trace state differ #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanwest merged 22 commits into from
Jan 16, 2024
Merged

Only create a sibling activity when trace id, span id or trace state differ #5136

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6d2c7ee
Do not create sibling activity when format is W3C
ngruson Dec 6, 2023
e516460
Formatted temp comments properly in unit tests
ngruson Dec 6, 2023
3e1af43
Conditional using statement
ngruson Dec 6, 2023
cb50735
Create sibling activity when format != W3C or trace flags is Recorded
ngruson Dec 6, 2023
a3c6d65
Leave trace flags out of comparison to create sibling activity
ngruson Dec 6, 2023
a76e470
Use WebApplicationFactory
ngruson Dec 7, 2023
0ab1901
Added Microsoft.Extensions.Features to Directory.Packages.props
ngruson Dec 7, 2023
f0c8152
Merge branch 'main' into 4466-bug-httpactivityfeature
ngruson Dec 7, 2023
d582a92
Updated trace id/span id/trace state comparison
ngruson Dec 8, 2023
0e26e0b
Merge branch 'main' into 4466-bug-httpactivityfeature
ngruson Dec 8, 2023
98c8feb
Add comment and compare Activity.Current to IHttpFeatureActivityFeatu…
ngruson Dec 8, 2023
83ce8b3
Merge branch 'main' into 4466-bug-httpactivityfeature
cijothomas Dec 8, 2023
ba7b218
Merge branch 'main' into 4466-bug-httpactivityfeature
ngruson Dec 19, 2023
f1df768
Merge branch '4466-bug-httpactivityfeature' of https://github.com/ngr…
ngruson Dec 19, 2023
462287e
Merge branch 'main' into 4466-bug-httpactivityfeature
ngruson Dec 20, 2023
2aa9fd9
Don't create ActivityContext struct for comparison
ngruson Dec 21, 2023
219ceed
Merge branch 'main' into 4466-bug-httpactivityfeature
ngruson Dec 27, 2023
b3cb1e2
Added PR #5136 to CHANGELOG.md
ngruson Jan 8, 2024
61a3bcb
Fixed trailing spaces
ngruson Jan 8, 2024
9837992
Merge branch 'main' into 4466-bug-httpactivityfeature
CodeBlanch Jan 8, 2024
e0b013e
Merge branch 'main' into 4466-bug-httpactivityfeature
alanwest Jan 16, 2024
f842030
Merge branch 'main' into 4466-bug-httpactivityfeature
alanwest Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into 4466-bug-httpactivityfeature
  • Loading branch information
@cijothomas
cijothomas authored Dec 8, 2023
commit 83ce8b376a8063c3739a2d93c42d7ad7cf04c534

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.