Skip to content

[Instrumentation.GrpcNetClient] Support only stable HTTP semantic convention #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanwest merged 6 commits into from
Jan 27, 2024
Merged

[Instrumentation.GrpcNetClient] Support only stable HTTP semantic convention #5259

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ca3aaf
[Instrumentation.GrpcNetClient] Support only stable HTTP semantic con…
Kielek Jan 26, 2024
6e84e43
Update src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md
Kielek Jan 26, 2024
3689c85
Merge branch 'main' into grpncnetclient-drop-supporto-for-old-http-se…
Kielek Jan 26, 2024
d7b7a7f
Merge branch 'main' into grpncnetclient-drop-supporto-for-old-http-se…
cijothomas Jan 26, 2024
15bae65
Update src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md
Kielek Jan 27, 2024
0d4f0c0
Merge branch 'main' into grpncnetclient-drop-supporto-for-old-http-se…
Kielek Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md 
Co-authored-by: Reiley Yang <[email protected]>
  • Loading branch information
@Kielek @reyang
Kielek and reyang authored Jan 26, 2024
commit 6e84e4336071a308813f206c99e18f636978fdbb
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Instrumentation.GrpcNetClient/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
[issue](https://github.com/open-telemetry/opentelemetry-dotnet/issues/5092)
for details and workaround.
([#5077](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5077))
* Removed support for `http` and `http/dup` values for`OTEL_SEMCONV_STABILITY_OPT_IN`
environment variable. The library will now emit only the
* Removed `OTEL_SEMCONV_STABILITY_OPT_IN` environment variable support. The
Copy link
Member

@cijothomas cijothomas Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question .. The grpc conventions are still not stable and this instrumentaion is still emitting them. Should we explicitly call it out, to avoid giving the feel that the entire conventions emitted by this is stable?

Copy link
Member

@reyang reyang Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, folks who want to spend time reading changelog should already know semver2.

library will now emit the
[stable](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http)
HTTP semantic conventions.
([#5259](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5259))
Expand Down