Skip to content

[sdk-metrics] ExemplarFilter updates to match latest specification #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 8 commits into from
Mar 1, 2024
Merged

[sdk-metrics] ExemplarFilter updates to match latest specification #5404

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2acba3a
ExemplarFilter updates to match specification.
CodeBlanch Mar 1, 2024
18cfb2d
Make ExemplarFilterType an experimental API.
CodeBlanch Mar 1, 2024
1073a12
CHANGELOG patch.
CodeBlanch Mar 1, 2024
0884011
Code review.
CodeBlanch Mar 1, 2024
ce1e34e
Code review.
CodeBlanch Mar 1, 2024
af79723
Doc updates.
CodeBlanch Mar 1, 2024
6963b0c
Test case.
CodeBlanch Mar 1, 2024
1c75977
Benchmark improvements.
CodeBlanch Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CHANGELOG patch.
  • Loading branch information
@CodeBlanch
CodeBlanch committed Mar 1, 2024
commit 1073a12b7e82ff0c136c5e7b05ea99b88f73dccc
10 changes: 10 additions & 0 deletions src/OpenTelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@
API.
([#5396](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5396))

* **Experimental (pre-release builds only):** Removed the `ExemplarFilter`,
Copy link
Member

@cijothomas cijothomas Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice wording! crisp and clear. 💯

`AlwaysOffExemplarFilter`, `AlwaysOnExemplarFilter`, and
`TraceBasedExemplarFilter` APIs. The `MeterProviderBuilder.SetExemplarFilter`
extension method now accepts an `ExemplarFilterType` enumeration (which
contains definitions for the supported filter types `AlwaysOff`, `AlwaysOn`,
and `TraceBased`) instead of an `ExemplarFilter` instance. This was done in
response to changes made to the [OpenTelemetry Metrics SDK
Specification](https://github.com/open-telemetry/opentelemetry-specification/pull/3820).
([#5404](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5404))

## 1.7.0

Released 2023-Dec-08
Expand Down