Skip to content

[docs-traces] Added version info to the OTEL_TRACES_SAMPLER doc #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 1 commit into from
Mar 29, 2024
Merged

[docs-traces] Added version info to the OTEL_TRACES_SAMPLER doc #5492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/trace/customizing-the-sdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ var tracerProvider = Sdk.CreateTracerProviderBuilder()
.Build();
```

It is also possible to configure the sampler by using the following
environmental variables:
If using `1.8.0-rc.1` or newer it is also possible to configure the sampler by
using the following environmental variables:

| Environment variable | Description |
| -------------------------- | -------------------------------------------------- |
Expand Down
7 changes: 1 addition & 6 deletions src/OpenTelemetry/Trace/TracerProviderSdk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,12 +407,7 @@ protected override void Dispose(bool disposing)

private static Sampler GetSampler(IConfiguration configuration, Sampler? stateSampler)
{
Sampler? sampler = null;

if (stateSampler != null)
{
sampler = stateSampler;
}
var sampler = stateSampler;

if (configuration.TryGetStringValue(TracesSamplerConfigKey, out var configValue))
{
Expand Down