Skip to content

[Instrumentation.Http][Instrumentation.AspNetCore] Fix url.full and url.query attribute values #5532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 8 commits into from
Apr 12, 2024
Merged

[Instrumentation.Http][Instrumentation.AspNetCore] Fix url.full and url.query attribute values #5532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
861b556
redaction
vishweshbankwar Apr 11, 2024
85a5c79
readme updates
vishweshbankwar Apr 11, 2024
76d0ed4
review
vishweshbankwar Apr 12, 2024
2a15b5d
better comment
vishweshbankwar Apr 12, 2024
8db768e
changelog
vishweshbankwar Apr 12, 2024
e2d1d7e
Merge branch 'main' into vibankwa/redact-http-attributes
vishweshbankwar Apr 12, 2024
2903ac7
PR link
vishweshbankwar Apr 12, 2024
b6fde65
Merge branch 'vibankwa/redact-http-attributes' of https://github.com/…
vishweshbankwar Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changelog
  • Loading branch information
@vishweshbankwar
vishweshbankwar committed Apr 12, 2024
commit 8db768ef2512b328e8ef2e9c98777c537e14380c
12 changes: 11 additions & 1 deletion src/OpenTelemetry.Instrumentation.AspNetCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
# Changelog

## Unreleased
## 1.8.1

Released 2024-Apr-12

* **Breaking Change**: Fixed tracing instrumentation so that by default any
Copy link
Member

@cijothomas cijothomas Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is not very clear. Could we make it clear the why here as well?
Also, using the word "tag" may not be obvious that it is referring to "attributes".

values detected in the query string component of requests are replaced with
the text "Redacted" when building the `url.query` tag. For example,
`?key1=value1&key2=value2` becomes `?key1=Redacted&key2=Redacted`. You can
disable this redaction by setting the environment variable
`OTEL_DOTNET_EXPERIMENTAL_ASPNETCORE_DISABLE_URL_QUERY_REDACTION` to `true`.
([]())

## 1.8.0

Expand Down
12 changes: 11 additions & 1 deletion src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
# Changelog

## Unreleased
## 1.8.1

Released 2024-Apr-12

* **Breaking Change**: Fixed tracing instrumentation so that by default any
values detected in the query string component of requests are replaced with
the text "Redacted" when building the `url.full` tag. For example,
`?key1=value1&key2=value2` becomes `?key1=Redacted&key2=Redacted`. You can
disable this redaction by setting the environment variable
`OTEL_DOTNET_EXPERIMENTAL_HTTPCLIENT_DISABLE_URL_QUERY_REDACTION` to `true`.
([]())

## 1.8.0

Expand Down