Skip to content

[prometheus] Fix issue with corrupted buffers when reading both OpenMetrics and plain text formats #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 10 commits into from
May 17, 2024
Merged

[prometheus] Fix issue with corrupted buffers when reading both OpenMetrics and plain text formats #5623

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e59472
Fix issue supporting openmetrics and plain text for prometheus exporter
robertcoltheart May 16, 2024
519dfcc
Add tests and docs
robertcoltheart May 16, 2024
f212bfa
Fix changelog
robertcoltheart May 16, 2024
b19843d
Remove test code
robertcoltheart May 16, 2024
b7c8ae6
Fix lint issues
robertcoltheart May 16, 2024
fce5155
Update src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md
robertcoltheart May 16, 2024
fa44580
Update src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md
robertcoltheart May 16, 2024
ad8fdaa
Update PrometheusExporterMiddlewareTests.cs
robertcoltheart May 16, 2024
c211ba3
Merge branch 'main' into feature/support-both-formats
vishweshbankwar May 16, 2024
2e62fde
Merge branch 'main' into feature/support-both-formats
CodeBlanch May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update PrometheusExporterMiddlewareTests.cs
  • Loading branch information
@robertcoltheart
robertcoltheart authored May 16, 2024
commit ad8fdaa0b9b502fec77c84242e3d5b7ed077ce12
2 changes: 1 addition & 1 deletion test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/PrometheusExporterMiddlewareTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ public async Task PrometheusExporterMiddlewareIntegration_CanServeOpenMetricsAnd
counter.Add(100.18D, tags);
counter.Add(0.99D, tags);

var testCases = new bool[] { true, false };
var testCases = new bool[] { true, false, true, true, false };

using var client = host.GetTestClient();

Expand Down