Fix thread-safety issue in LogRecordSharedPool.Rent()#6833
Merged
rajkumar-rangaraj merged 9 commits intoopen-telemetry:mainfrom Feb 17, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6233
Changes
This PR fixes a thread-safety issue in
LogRecordSharedPool.Rent()where the same LogRecord instance could be rented to multiple threads concurrently under high contention.continueand retry with a new index, which could lead to a duplicate rental.slotIndexcalculation to avoid redundant modulo operations.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes