Skip to content

Catch exceptions in flush timer and write to EventSource #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeGoldsmith merged 8 commits into from
May 25, 2020
Merged

Catch exceptions in flush timer and write to EventSource #696

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4687dc0
Catch exceptions in flush timer and write to EventSource
Illia-M May 23, 2020
7ae1ec3
Fix naming
Illia-M May 23, 2020
6e116c1
Revert OpenTelemetryApiEventSource naming fix
Illia-M May 23, 2020
ccda96d
Remove whitespace changes
Illia-M May 23, 2020
d066ca4
Add missing header
Illia-M May 23, 2020
7612cc5
Change error handling
Illia-M May 24, 2020
1971379
Fix
Illia-M May 24, 2020
1c7fd6e
Merge branch 'master' into bugfix/#695_jaeger_unhandled_exception
Illia-M May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert OpenTelemetryApiEventSource naming fix
  • Loading branch information
@Illia-M
Illia-M committed May 23, 2020
commit 6e116c1699f0eb2a4630d4e9276477aa898ee044
6 changes: 3 additions & 3 deletions src/OpenTelemetry.Api/Internal/OpenTelemetryApiEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void SpanContextExtractException(Exception ex)
}

[NonEvent]
public void TraceStateExtractException(Exception ex)
public void TracestateExtractException(Exception ex)
{
if (this.IsEnabled(EventLevel.Warning, (EventKeywords)(-1)))
{
Expand All @@ -48,7 +48,7 @@ public void TraceStateExtractException(Exception ex)
}

[NonEvent]
public void TraceStateKeyIsInvalid(ReadOnlySpan<char> key)
public void TracestateKeyIsInvalid(ReadOnlySpan<char> key)
{
if (this.IsEnabled(EventLevel.Warning, (EventKeywords)(-1)))
{
Expand All @@ -57,7 +57,7 @@ public void TraceStateKeyIsInvalid(ReadOnlySpan<char> key)
}

[NonEvent]
public void TraceStateValueIsInvalid(ReadOnlySpan<char> value)
public void TracestateValueIsInvalid(ReadOnlySpan<char> value)
{
if (this.IsEnabled(EventLevel.Warning, (EventKeywords)(-1)))
{
Expand Down