Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 25, 2025

  • Fix metric instantiation to use semconv not one-off strings (requires upgrade to semconv)
  • Remove custom attribute names, replace with version from semconv (requires upgrade to semconv)
  • Upgrade all semconv to v1.30.0:
    • v1.21.0 upgrade:

      Rename net.peer.*, net.host.*, and net.sock.* attributes to align with ECS (#3402)
      BREAKING: rename net.peer.name to server.address on client side and to client.address on server side, net.peer.port to server.port on client side and to client.port on server side, net.host.name and net.host.port to server.address and server.port (since net.host.* attributes only applied to server instrumentation), net.sock.peer.addr to server.socket.address on client side and to client.socket.address on server side, net.sock.peer.port to server.socket.port on client side and to client.socket.port on server side, net.sock.peer.name to server.socket.domain (since net.sock.peer.name only applied to client instrumentation), net.sock.host.addr to server.socket.address (since net.sock.host.* only applied to server instrumentation), net.sock.host.port to server.socket.port (similarly since net.sock.host.* only applied to server instrumentation), http.client_ip to client.address

    • v1.22.0 upgrade:

      BREAKING: Remove server.socket.address from HTTP and RPC client metrics. (#350)

@MrAlias MrAlias added this to the v1.36.0 milestone Apr 25, 2025
@github-actions github-actions bot requested a review from dashpole April 25, 2025 17:40
@MrAlias MrAlias changed the title Upgrade semantic conventions in otelgrpc Upgrade semantic conventions in otelgrpc from v1.17.0 to v1.30.0 Apr 28, 2025
@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.1%. Comparing base (b658ecf) to head (00798e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 93.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7270   +/-   ##
=====================================
  Coverage   81.1%   81.1%           
=====================================
  Files        204     204           
  Lines      18151   18140   -11     
=====================================
- Hits       14728   14720    -8     
+ Misses      3003    3001    -2     
+ Partials     420     419    -1     
Files with missing lines Coverage Δ
...entation/google.golang.org/grpc/otelgrpc/config.go 81.5% <ø> (ø)
.../google.golang.org/grpc/otelgrpc/internal/parse.go 100.0% <ø> (ø)
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 98.9% <100.0%> (ø)
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 87.1% <93.7%> (+0.6%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias marked this pull request as ready for review April 28, 2025 16:10
@MrAlias MrAlias requested a review from a team as a code owner April 28, 2025 16:10
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@MrAlias MrAlias merged commit f0a5e84 into open-telemetry:main Apr 29, 2025
28 checks passed
@MrAlias MrAlias deleted the fix-7258 branch April 29, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants