Skip to content

Add selector of exemplar reservoir providers to metric.Stream configuration #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashpole merged 8 commits into from
Oct 18, 2024
Merged

Add selector of exemplar reservoir providers to metric.Stream configuration #5861

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1932874
Add selector of exemplar reservoir providers to metric.Stream configu…
dashpole Oct 1, 2024
849611f
ExemplarProvider takes attributes as an argument
dashpole Oct 1, 2024
621a83b
plumb selector to reservoir func
dashpole Oct 15, 2024
f4ca6b7
add example for ExemplarReservoirProviderSelector
dashpole Oct 15, 2024
0f1ab73
add unit tests
dashpole Oct 15, 2024
3ad5d8e
Update sdk/metric/exemplar.go
dashpole Oct 17, 2024
46de771
Update sdk/metric/exemplar.go
dashpole Oct 17, 2024
313f237
Merge branch 'main' into stream_reservoir
pellared Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update sdk/metric/exemplar.go 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
  • Loading branch information
@dashpole @MrAlias
dashpole and MrAlias authored Oct 17, 2024
commit 3ad5d8efc9cfcef8846dee965a3e7086a7af301e
2 changes: 1 addition & 1 deletion sdk/metric/exemplar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
)

// ExemplarReservoirProviderSelector selects the
// [go.opentelemetry.io/otel/sdk/metric/exemplar.ReservoirProvider] to use
// [exemplar.ReservoirProvider] to use
// based on the [Aggregation] of the metric.
type ExemplarReservoirProviderSelector func(Aggregation) exemplar.ReservoirProvider

Expand Down