Skip to content

Attempt to align and cleanup some jmx metrics #11621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SylvainJuge wants to merge 17 commits into from
Closed

Attempt to align and cleanup some jmx metrics #11621

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
02b5448
tomcat prefix + fix busy/idle threads
SylvainJuge Jun 18, 2024
cf15127
tomcat align network metric/attributes
SylvainJuge Jun 18, 2024
d450d9a
wildfly align 'sessions' in plural form
SylvainJuge Jun 18, 2024
5c7688b
wildfly align network.io with semconv attributes
SylvainJuge Jun 18, 2024
4b966cc
update documentation
SylvainJuge Jun 18, 2024
2349720
clarify doc
SylvainJuge Jun 18, 2024
cc85a16
doc again
SylvainJuge Jun 18, 2024
64e9cdd
reformat example
SylvainJuge Jun 18, 2024
aa41343
jetty singular thread metrics
SylvainJuge Jun 18, 2024
3f9b71e
tomcat move to 'request' namespace
SylvainJuge Jun 18, 2024
fe09251
tomcat singular session
SylvainJuge Jun 18, 2024
931032b
singular units + tomcat fix
SylvainJuge Jun 18, 2024
313ed49
fix tomcat request reference + clarify a bit
SylvainJuge Jun 18, 2024
545a066
fix doc for tomcat.thread.*
SylvainJuge Jun 18, 2024
cb27853
wildfly align with upcoming semconv
SylvainJuge Jun 18, 2024
286d784
wildfly transaction name fits mbean attribute
SylvainJuge Jun 18, 2024
fb71fa1
simplify metrics for wildfly
SylvainJuge Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tomcat request reference + clarify a bit
  • Loading branch information
@SylvainJuge
SylvainJuge committed Jun 18, 2024
commit 313ed49042f9a75319fe8cdcdc16155bc738e8c0
2 changes: 1 addition & 1 deletion instrumentation/jmx-metrics/javaagent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The following guidelines are recommended when modifying/extending pre-defined me
- start with `{target}.` prefix, where `{target}` is the target system, for example `tomcat` or `hadoop`.
- align with semconv when semantics are identical, for example:
- `wildfly.network.io` is consistent with [`system.network.io`](https://opentelemetry.io/docs/specs/semconv/system/system-metrics/#metric-systemnetworkio)
- when not fitting semconv, reuse the existing mbean attribute names as metric suffix to preserve semantics, for example `tomcat.errorCount` where tomcat reports as error any status >=400 and another app server might do differently.
- when not fitting semconv, reuse the existing mbean attribute names as metric suffix to preserve semantics of the exposed MBeans, for example `tomcat.request.errorCount` where tomcat reports as error any status >=400 and another app server might do it differently.

## Configuration Files

Expand Down