Skip to content

add ComponentLoader to support more auto configuration scenarios #6217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 21 commits into from
Mar 6, 2024
Merged

add ComponentLoader to support more auto configuration scenarios #6217

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0531869
add ComponentLoader to support more auto configuration scenarios, e.g…
zeitlinger Feb 9, 2024
6d51896
format
zeitlinger Feb 13, 2024
2b9fb28
add loadOptional
zeitlinger Feb 13, 2024
e1352d6
customizers are sufficient
zeitlinger Feb 19, 2024
091b19b
ExemplarFilter is going to be removed from public API, so don't expos…
zeitlinger Feb 19, 2024
eac57ca
customizers are sufficient
zeitlinger Feb 19, 2024
ae2c633
add exception for jcmpapi
zeitlinger Feb 19, 2024
2bec27f
jcmpapi
zeitlinger Feb 19, 2024
ad4047f
test component loader is used
zeitlinger Feb 19, 2024
5336d59
Revert "customizers are sufficient"
zeitlinger Feb 19, 2024
44df716
add loader for ConfigProperties
zeitlinger Feb 19, 2024
74322cd
Revert "add loader for ConfigProperties"
zeitlinger Feb 20, 2024
5799589
Revert "Revert "customizers are sufficient""
zeitlinger Feb 20, 2024
3f574fb
add loader for ConfigProperties
zeitlinger Feb 20, 2024
6d06755
make component loader internal to give it time to incubate
zeitlinger Feb 23, 2024
42d6e17
remove ConfigurableProvider
zeitlinger Feb 28, 2024
d03a67f
add javadoc
zeitlinger Feb 28, 2024
517d773
make new methods experimental
zeitlinger Feb 28, 2024
e97c4f9
don't make loadOrdered overridable
zeitlinger Feb 29, 2024
4519a7e
add setConfigPropertiesCustomizer
zeitlinger Feb 29, 2024
22996e0
add setConfigPropertiesCustomizer
zeitlinger Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add exception for jcmpapi
  • Loading branch information
@zeitlinger
zeitlinger committed Feb 28, 2024
commit ae2c633fd78d2f8361c0b98fd25f0d6161f807d7
2 changes: 2 additions & 0 deletions buildSrc/src/main/kotlin/otel.japicmp-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ if (!project.hasProperty("otel.release") && !project.name.startsWith("bom")) {
// Reproduce defaults from https://github.com/melix/japicmp-gradle-plugin/blob/09f52739ef1fccda6b4310cf3f4b19dc97377024/src/main/java/me/champeau/gradle/japicmp/report/ViolationsGenerator.java#L130
// with some changes.
val exclusions = mutableListOf<String>()
// Generics are not detected correctly
exclusions.add("CLASS_GENERIC_TEMPLATE_CHANGED")
Copy link
Member

@jack-berg jack-berg Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need this anymore.

Copy link
Member Author

@zeitlinger zeitlinger Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR - but it's still true that jApiCmp will trip over generics - I'm fine to take it out, of course.

// Allow new default methods on interfaces
exclusions.add("METHOD_NEW_DEFAULT")
// Allow adding default implementations for default methods
Expand Down