Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: do not create new noops on every call
  • Loading branch information
dyladan committed Apr 29, 2021
commit 79dbb9d24e5ba87fe01bd5f3ff6f18f8abf7d70d
3 changes: 2 additions & 1 deletion src/api/context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
} from '../internal/global-utils';

const API_NAME = 'context';
const NOOP_CONTEXT_MANAGER = new NoopContextManager();

/**
* Singleton object which represents the entry point to the OpenTelemetry Context API
Expand Down Expand Up @@ -86,7 +87,7 @@ export class ContextAPI {
}

private _getContextManager(): ContextManager {
return getGlobal(API_NAME) || new NoopContextManager();
return getGlobal(API_NAME) || NOOP_CONTEXT_MANAGER;
}

/** Disable and remove the global context manager */
Expand Down
3 changes: 2 additions & 1 deletion src/api/propagation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
} from '../propagation/TextMapPropagator';

const API_NAME = 'propagation';
const NOOP_TEXT_MAP_PROPAGATOR = new NoopTextMapPropagator();

/**
* Singleton object which represents the entry point to the OpenTelemetry Propagation API
Expand Down Expand Up @@ -101,6 +102,6 @@ export class PropagationAPI {
}

private _getGlobalPropagator(): TextMapPropagator {
return getGlobal(API_NAME) || new NoopTextMapPropagator();
return getGlobal(API_NAME) || NOOP_TEXT_MAP_PROPAGATOR;
}
}
6 changes: 3 additions & 3 deletions src/trace/ProxyTracerProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { NoopTracerProvider } from './NoopTracerProvider';
* all tracers already provided will use the provided delegate implementation.
*/
export class ProxyTracerProvider implements TracerProvider {
private _delegate?: TracerProvider;
private _delegate: TracerProvider = new NoopTracerProvider();

/**
* Get a {@link ProxyTracer}
Expand All @@ -41,7 +41,7 @@ export class ProxyTracerProvider implements TracerProvider {
}

getDelegate(): TracerProvider {
return this._delegate ?? new NoopTracerProvider();
return this._delegate;
}

/**
Expand All @@ -52,6 +52,6 @@ export class ProxyTracerProvider implements TracerProvider {
}

getDelegateTracer(name: string, version?: string): Tracer | undefined {
return this._delegate?.getTracer(name, version);
return this._delegate.getTracer(name, version);
}
}