Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix tests to ignore the messages created in setup
  • Loading branch information
rauno56 committed May 19, 2021
commit 15f4a0806020471e9b644ac959dbf5a24fbb7d8a
6 changes: 2 additions & 4 deletions test/diag/ComponentLogger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,9 @@ import { diag, DiagLogger, DiagLogLevel } from '../../src';

class SpyLogger implements DiagLogger {
debug() {}

error() {}

info() {}

warn() {}

verbose() {}
}

Expand All @@ -41,6 +37,8 @@ describe('ComponentLogger', () => {
logger = new SpyLogger();
sandbox.spy(logger);
diag.setLogger(logger, DiagLogLevel.ALL);
// clean any messages up that might be there from the registration
sandbox.reset();
});

afterEach(() => {
Expand Down
1 change: 1 addition & 0 deletions test/diag/logLevel.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ describe('LogLevelFilter DiagLogger', () => {

it('diag.setLogger level and logger should log', () => {
diag.setLogger(dummyLogger, map.level);
restoreCallHistory();
diag[fName](`${fName} called %s`, 'param1');
diagLoggerFunctions.forEach(lName => {
if (fName === lName && map.ignoreFuncs.indexOf(lName) === -1) {
Expand Down
12 changes: 8 additions & 4 deletions test/diag/logger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ describe('DiagLogger functions', () => {

let dummyLogger: DiagLogger;

const restoreCallHistory = () => {
diagLoggerFunctions.forEach(fName => {
calledArgs[fName] = null;
});
};

beforeEach(() => {
// mock
dummyLogger = {} as DiagLogger;
Expand All @@ -49,10 +55,7 @@ describe('DiagLogger functions', () => {
});

afterEach(() => {
// restore
diagLoggerFunctions.forEach(fName => {
calledArgs[fName] = null;
});
restoreCallHistory();
diag.disable();
});

Expand All @@ -75,6 +78,7 @@ describe('DiagLogger functions', () => {

it(`diag should log with ${fName} message`, () => {
diag.setLogger(dummyLogger, DiagLogLevel.ALL);
restoreCallHistory();
diag[fName](`${fName} called %s`, 'param1');
diagLoggerFunctions.forEach(lName => {
if (fName === lName) {
Expand Down