Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

chore: function overloads implementation of startActiveSpan in noop t… #81

Merged
dyladan merged 9 commits into from
Jun 1, 2021
Merged

chore: function overloads implementation of startActiveSpan in noop t… #81

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e82a95b
chore: function overloads implementation of startActiveSpan in noop t…
May 21, 2021
815cb2f
chore: change var names
May 22, 2021
77e3490
refactor: call startActiveSpan directly in assertion
May 22, 2021
a0a187c
test: wrong usage to increase coverage
May 22, 2021
9c6f23e
Update src/trace/NoopTracer.ts
May 24, 2021
1a78b42
Update src/trace/NoopTracer.ts
May 24, 2021
54fa2a9
Merge branch 'main' into tracer-start-active-span
dyladan May 27, 2021
ff73a3c
Merge branch 'main' into tracer-start-active-span
May 31, 2021
5217cc8
Merge branch 'main' into tracer-start-active-span
vmarchaud Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: wrong usage to increase coverage 
Signed-off-by: naseemkullah <[email protected]>
  • Loading branch information
naseemkullah committed May 22, 2021
commit a0a187c9f27ebbcdd0c3f05475d5458eb5662484
2 changes: 2 additions & 0 deletions test/noop-implementations/noop-tracer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ describe('NoopTracer', () => {
};
const opts = { attributes: { foo: 'bar' } };

assert.strictEqual((tracer as any).startActiveSpan(name), undefined);

assert.strictEqual(tracer.startActiveSpan(name, fn), 1);

assert.strictEqual(tracer.startActiveSpan(name, opts, fn), 1);
Expand Down