Skip to content

feat(dns): Add option to include name as attribute in dns lookup #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evantorrie wants to merge 9 commits into from
Closed

feat(dns): Add option to include name as attribute in dns lookup #1178

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc7f283
Introduce addHostnameAttribute to dns.instrumentation
evantorrie Sep 11, 2022
55c81e7
Change configuration setting to `includeHostname`
evantorrie Sep 15, 2022
cdc3dd9
Merge branch 'main' into dns.hostname
evantorrie Sep 16, 2022
5a267b9
Merge branch 'main' into dns.hostname
evantorrie Sep 20, 2022
3bc9b18
Merge branch 'main' into dns.hostname
evantorrie Oct 8, 2022
5044801
fix(dns): correct check for empty dns.hostname attribute
evantorrie Oct 9, 2022
4af465f
fix(dns): flip includeHostname to omitHostnameAttribute
evantorrie Oct 9, 2022
8cb821c
Merge remote-tracking branch 'upstream/main' into dns.hostname
evantorrie Oct 10, 2022
bfa6cae
fixup! Merge remote-tracking branch 'upstream/main' into dns.hostname
evantorrie Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into dns.hostname
  • Loading branch information
@evantorrie
evantorrie committed Oct 10, 2022
commit 8cb821c9637f63e94d289bcb0f78543f9e4f6ebf
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-instrumentation-dns/test/integrations/dnspromise-lookup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('dns.promises.lookup()', () => {

it('should export a valid span with error NOT_FOUND', async () => {
try {
await lookupPromise(unresolvableHostname);
await dns.promises.lookup(unresolvableHostname);
assert.fail();
} catch (error) {
const spans = memoryExporter.getFinishedSpans();
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.