Skip to content

Conversation

@Flarna
Copy link
Member

@Flarna Flarna commented Apr 5, 2023

Exclude examples from renovate runs because there is no CI to verify that they still work after the update.

As they are terrible outdated already any update is likely breaking them because some still use components not released anymore and therefore no compatibility to actual release without code change.

Refs: #1459

@Flarna Flarna requested a review from a team April 5, 2023 09:45
@dyladan dyladan merged commit fd5f87e into open-telemetry:main Apr 5, 2023
@Flarna Flarna deleted the renovate-no-examples branch April 5, 2023 21:01
@trentm
Copy link
Contributor

trentm commented Nov 14, 2023

@Flarna Was it intentional that the .husky/... file was deleted as part of this change.
I got here because #1788 recently updated the @commitlint/cli dep. I started looking for a usage of the commitlint CLI in this repo and couldn't find it.

@Flarna
Copy link
Member Author

Flarna commented Nov 14, 2023

Sorry, can't remember for sure. Long time ago husky was used to avoid malformed commits already in user repo via husky. That was terrible annoying and therefore removed. e.g. there is anyway no need to have validated commit message on each commit because we squash during integration and commits done in browser skipped the check.

I think in core repo a CI lint step checks the commit message meanwhile but contrib repo tends to be behind regarding tooling. I guess there are some leftovers.

Refs: open-telemetry/opentelemetry-js#2078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants