Skip to content

chore: clean up span naming #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obecny merged 3 commits into from
Jul 31, 2020
Merged

chore: clean up span naming #162

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba4868b
chore: clean up span naming
johnbley Jul 24, 2020
b90c152
chore: _ name prefix for allowEventType
johnbley Jul 29, 2020
187e2ad
chore: remove dblclick from traced events
johnbley Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: _ name prefix for allowEventType
  • Loading branch information
@johnbley
johnbley committed Jul 29, 2020
commit b90c1529759f485aeaba77bcdc694c7ea509867a
4 changes: 2 additions & 2 deletions plugins/web/opentelemetry-plugin-user-interaction/src/userInteraction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class UserInteractionPlugin extends BasePlugin<unknown> {
/**
* Controls whether or not to create a span, based on the event type.
*/
protected allowEventType(eventType: string): boolean {
protected _allowEventType(eventType: string): boolean {
return eventType === 'click' || eventType === 'dblclick';
}
/**
Expand All @@ -100,7 +100,7 @@ export class UserInteractionPlugin extends BasePlugin<unknown> {
if (element.hasAttribute('disabled')) {
return undefined;
}
if (!this.allowEventType(eventName)) {
if (!this._allowEventType(eventName)) {
return undefined;
}
const xpath = getElementXPath(element, true);
Expand Down