[Plugin User Interaction]: Improve causality of spans from bubbled events#172
Merged
obecny merged 4 commits intoopen-telemetry:masterfrom Aug 18, 2020
johnbley:master
Merged
[Plugin User Interaction]: Improve causality of spans from bubbled events#172obecny merged 4 commits intoopen-telemetry:masterfrom johnbley:master
obecny merged 4 commits intoopen-telemetry:masterfrom
johnbley:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 77 77
Lines 3830 3836 +6
Branches 413 415 +2
=======================================
+ Hits 3612 3618 +6
Misses 218 218
|
dyladan
reviewed
Aug 10, 2020
plugins/web/opentelemetry-plugin-user-interaction/src/userInteraction.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
obecny
reviewed
Aug 14, 2020
Member
obecny
left a comment
There was a problem hiding this comment.
overall lgtm, I just would like to ask you to update the image images/main-sync.jpg to show how the trace will look like now after this change.
plugins/web/opentelemetry-plugin-user-interaction/src/userInteraction.ts
Outdated
Show resolved
Hide resolved
Member
Author
There's no difference in the examples because of this change - this only affects scenarios where event listeners on bubbling events are added at multiple levels of the DOM tree, which the examples don't do. |
obecny
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes